From 431a9c00a56cf4c603be1cf5f773b193621d8150 Mon Sep 17 00:00:00 2001 From: Kai Blaschke Date: Mon, 19 Feb 2024 16:55:19 +0100 Subject: Fixed a huge amount of Clang warnings On Linux and macOS, using Clang to compile OpenStarbound produces about 400 MB worth of warnings during the build, making the compiler output unreadable and slowing the build down considerably. 99% of the warnings were unqualified uses of std::move and std::forward, which are now all properly qualified. Fixed a few other minor warnings about non-virtual destructors and some uses of std::move preventing copy elision on temporary objects. Most remaining warnings are now unused parameters. --- source/game/StarSystemWorldClient.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'source/game/StarSystemWorldClient.cpp') diff --git a/source/game/StarSystemWorldClient.cpp b/source/game/StarSystemWorldClient.cpp index da28c98..eb25124 100644 --- a/source/game/StarSystemWorldClient.cpp +++ b/source/game/StarSystemWorldClient.cpp @@ -7,7 +7,7 @@ namespace Star { SystemWorldClient::SystemWorldClient(ClockConstPtr universeClock, CelestialDatabasePtr celestialDatabase, PlayerUniverseMapPtr universeMap) - : SystemWorld(universeClock, celestialDatabase), m_universeMap(move(universeMap)) {} + : SystemWorld(universeClock, celestialDatabase), m_universeMap(std::move(universeMap)) {} CelestialCoordinate SystemWorldClient::currentSystem() const { return CelestialCoordinate(m_location); @@ -102,7 +102,7 @@ SystemClientShipPtr SystemWorldClient::getShip(Uuid const & uuid) const Uuid SystemWorldClient::spawnObject(String typeName, Maybe position, Maybe const& uuid, JsonObject overrides) { Uuid objectUuid = uuid.value(Uuid()); - m_outgoingPackets.append(make_shared(move(typeName), objectUuid, move(position), move(overrides))); + m_outgoingPackets.append(make_shared(std::move(typeName), objectUuid, std::move(position), std::move(overrides))); return objectUuid; } @@ -165,7 +165,7 @@ List SystemWorldClient::pullOutgoingPackets() { } SystemObjectPtr SystemWorldClient::netLoadObject(ByteArray netStore) { - DataStreamBuffer ds(move(netStore)); + DataStreamBuffer ds(std::move(netStore)); Uuid uuid = ds.read(); String name = ds.read(); @@ -179,7 +179,7 @@ SystemObjectPtr SystemWorldClient::netLoadObject(ByteArray netStore) { SystemClientShipPtr SystemWorldClient::netLoadShip(ByteArray netStore) { - DataStreamBuffer ds(move(netStore)); + DataStreamBuffer ds(std::move(netStore)); Uuid uuid = ds.read(); SystemLocation location = ds.read(); return make_shared(this, uuid, location); -- cgit v1.2.3