From 332983c97b7a729c4dc5f19aa9ee4a22c420f7d8 Mon Sep 17 00:00:00 2001 From: Kae <80987908+Novaenia@users.noreply.github.com> Date: Tue, 27 Jun 2023 20:23:44 +1000 Subject: The Formatting String Catastrophe --- source/core/StarException_windows.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'source/core/StarException_windows.cpp') diff --git a/source/core/StarException_windows.cpp b/source/core/StarException_windows.cpp index 7fd386c..54254d4 100644 --- a/source/core/StarException_windows.cpp +++ b/source/core/StarException_windows.cpp @@ -127,9 +127,9 @@ OutputProxy outputStack(StackCapture stack) { symbol->MaxNameLen = MAX_SYM_NAME; DWORD64 displacement = 0; - format(os, "[%i] %p", i, stack.first[i]); + format(os, "[{}] {}", i, (void*)stack.first[i]); if (SymFromAddr(process, stack.first[i], &displacement, symbol)) - format(os, " %s", symbol->Name); + format(os, " {}", symbol->Name); if (i + 1 < stack.second) os << std::endl; @@ -224,7 +224,7 @@ OutputProxy outputException(std::exception const& e, bool fullStacktrace) { } void printStack(char const* message) { - Logger::info("Stack Trace (%s)...\n%s", message, outputStack(captureStack())); + Logger::info("Stack Trace ({})...\n{}", message, outputStack(captureStack())); } void fatalError(char const* message, bool showStackTrace) { -- cgit v1.2.3