From 431a9c00a56cf4c603be1cf5f773b193621d8150 Mon Sep 17 00:00:00 2001 From: Kai Blaschke Date: Mon, 19 Feb 2024 16:55:19 +0100 Subject: Fixed a huge amount of Clang warnings On Linux and macOS, using Clang to compile OpenStarbound produces about 400 MB worth of warnings during the build, making the compiler output unreadable and slowing the build down considerably. 99% of the warnings were unqualified uses of std::move and std::forward, which are now all properly qualified. Fixed a few other minor warnings about non-virtual destructors and some uses of std::move preventing copy elision on temporary objects. Most remaining warnings are now unused parameters. --- source/core/StarDataStreamDevices.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'source/core/StarDataStreamDevices.cpp') diff --git a/source/core/StarDataStreamDevices.cpp b/source/core/StarDataStreamDevices.cpp index 85e6d3f..58ec920 100644 --- a/source/core/StarDataStreamDevices.cpp +++ b/source/core/StarDataStreamDevices.cpp @@ -3,7 +3,7 @@ namespace Star { DataStreamFunctions::DataStreamFunctions(function reader, function writer) - : m_reader(move(reader)), m_writer(move(writer)) {} + : m_reader(std::move(reader)), m_writer(std::move(writer)) {} void DataStreamFunctions::readData(char* data, size_t len) { if (!m_reader) @@ -18,7 +18,7 @@ void DataStreamFunctions::writeData(char const* data, size_t len) { } DataStreamIODevice::DataStreamIODevice(IODevicePtr device) - : m_device(move(device)) {} + : m_device(std::move(device)) {} IODevicePtr const& DataStreamIODevice::device() const { return m_device; @@ -119,7 +119,7 @@ void DataStreamBuffer::reset(size_t newSize) { } void DataStreamBuffer::reset(ByteArray b) { - m_buffer->reset(move(b)); + m_buffer->reset(std::move(b)); } void DataStreamBuffer::readData(char* data, size_t len) { -- cgit v1.2.3