Fixed a huge amount of Clang warnings

On Linux and macOS, using Clang to compile OpenStarbound produces about 400 MB worth of warnings during the build, making the compiler output unreadable and slowing the build down considerably.

99% of the warnings were unqualified uses of std::move and std::forward, which are now all properly qualified.

Fixed a few other minor warnings about non-virtual destructors and some uses of std::move preventing copy elision on temporary objects.

Most remaining warnings are now unused parameters.

1 files changed, 4 insertions, 4 deletions

diff --git a/source/game/scripting/StarLuaComponents.cpp b/source/game/scripting/StarLuaComponents.cpp
index 2d7c819..9a1b1c4 100644
--- a/source/game/scripting/StarLuaComponents.cpp
+++ b/source/game/scripting/StarLuaComponents.cpp
@@ -17,14 +17,14 @@ StringList const& LuaBaseComponent::scripts() const {
 }
 
 void LuaBaseComponent::setScript(String script) {
-  setScripts({move(script)});
+  setScripts({std::move(script)});
 }
 
 void LuaBaseComponent::setScripts(StringList scripts) {
   if (initialized())
     throw LuaComponentException("Cannot call LuaWorldComponent::setScripts when LuaWorldComponent is initialized");
 
-  m_scripts = move(scripts);
+  m_scripts = std::move(scripts);
 }
 
 void LuaBaseComponent::addCallbacks(String groupName, LuaCallbacks callbacks) {
@@ -58,7 +58,7 @@ void LuaBaseComponent::setAutoReInit(bool autoReInit) {
 }
 
 void LuaBaseComponent::setLuaRoot(LuaRootPtr luaRoot) {
-  m_luaRoot = move(luaRoot);
+  m_luaRoot = std::move(luaRoot);
 }
 
 LuaRootPtr const& LuaBaseComponent::luaRoot() {
@@ -140,7 +140,7 @@ void LuaBaseComponent::contextShutdown() {}
 
 void LuaBaseComponent::setError(String error) {
   m_context.reset();
-  m_error = move(error);
+  m_error = std::move(error);
 }
 
 bool LuaBaseComponent::checkInitialization() {