Fixed a huge amount of Clang warnings

On Linux and macOS, using Clang to compile OpenStarbound produces about 400 MB worth of warnings during the build, making the compiler output unreadable and slowing the build down considerably.

99% of the warnings were unqualified uses of std::move and std::forward, which are now all properly qualified.

Fixed a few other minor warnings about non-virtual destructors and some uses of std::move preventing copy elision on temporary objects.

Most remaining warnings are now unused parameters.

1 files changed, 3 insertions, 3 deletions

diff --git a/source/game/StarStoredFunctions.cpp b/source/game/StarStoredFunctions.cpp
index 0db0356..7905f66 100644
--- a/source/game/StarStoredFunctions.cpp
+++ b/source/game/StarStoredFunctions.cpp
@@ -10,7 +10,7 @@ StoredFunction::StoredFunction(ParametricFunction<double, double> data) {
   if (data.empty())
     throw StoredFunctionException("StoredFunction constructor called on function with no data points");
 
-  m_function = move(data);
+  m_function = std::move(data);
 
   // Determine whether the function is monotonically increasing, monotonically
   // decreasing, totally flat (technically both monotonically increasing and
@@ -104,14 +104,14 @@ StoredFunction::SearchResult StoredFunction::search(double targetValue, double v
   return result;
 }
 
-StoredFunction2::StoredFunction2(MultiTable2D table) : table(move(table)) {}
+StoredFunction2::StoredFunction2(MultiTable2D table) : table(std::move(table)) {}
 
 double StoredFunction2::evaluate(double x, double y) const {
   return table.interpolate({x, y});
 }
 
 StoredConfigFunction::StoredConfigFunction(ParametricTable<int, Json> data) {
-  m_data = move(data);
+  m_data = std::move(data);
 }
 
 Json StoredConfigFunction::get(double value) const {