Cache certain item generation calls from interfaces

Helps a little with the lag from recipes when having crafting interfaces open, but it's still noticeable.
Also micro-optimized Root maintenance by unlocking the Root mutexes for their respective shared_ptrs earlier once we have our own shared_ptr.

1 files changed, 2 insertions, 2 deletions

diff --git a/source/game/StarQuestDescriptor.cpp b/source/game/StarQuestDescriptor.cpp
index 3709ef3..cb791e1 100644
--- a/source/game/StarQuestDescriptor.cpp
+++ b/source/game/StarQuestDescriptor.cpp
@@ -279,12 +279,12 @@ String questParamText(QuestParam const& parameter) {
 
   if (parameter.detail.is<QuestItem>()) {
     QuestItem item = parameter.detail.get<QuestItem>();
-    return itemDatabase->item(item.descriptor())->friendlyName();
+    return itemDatabase->itemShared(item.descriptor())->friendlyName();
 
   } else if (parameter.detail.is<QuestItemList>()) {
     QuestItemList itemList = parameter.detail.get<QuestItemList>();
     StringList itemStrings = itemList.transformed([&itemDatabase](ItemDescriptor const& itemDesc) -> String {
-      return strf("{} {}", itemDesc.count(), itemDatabase->item(itemDesc)->friendlyName());
+      return strf("{} {}", itemDesc.count(), itemDatabase->itemShared(itemDesc)->friendlyName());
     });
     return itemStrings.join(", ");