Fixed a huge amount of Clang warnings

On Linux and macOS, using Clang to compile OpenStarbound produces about 400 MB worth of warnings during the build, making the compiler output unreadable and slowing the build down considerably.

99% of the warnings were unqualified uses of std::move and std::forward, which are now all properly qualified.

Fixed a few other minor warnings about non-virtual destructors and some uses of std::move preventing copy elision on temporary objects.

Most remaining warnings are now unused parameters.

1 files changed, 3 insertions, 3 deletions

diff --git a/source/game/StarAnimation.cpp b/source/game/StarAnimation.cpp
index 8a1e9c1..9cbf88a 100644
--- a/source/game/StarAnimation.cpp
+++ b/source/game/StarAnimation.cpp
@@ -44,7 +44,7 @@ void Animation::setAngle(float angle) {
 }
 
 void Animation::setProcessing(DirectivesGroup processing) {
-  m_processing = move(processing);
+  m_processing = std::move(processing);
 }
 
 void Animation::setColor(Color color) {
@@ -52,7 +52,7 @@ void Animation::setColor(Color color) {
 }
 
 void Animation::setTag(String tagName, String tagValue) {
-  m_tagValues[move(tagName)] = move(tagValue);
+  m_tagValues[std::move(tagName)] = std::move(tagValue);
 }
 
 void Animation::clearTags() {
@@ -69,7 +69,7 @@ Drawable Animation::drawable(float pixelSize) const {
   if (m_appendFrame)
     baseFrame += ":" + toString(m_frame);
 
-  Drawable drawable = Drawable::makeImage(move(baseFrame), pixelSize, m_centered, m_offset);
+  Drawable drawable = Drawable::makeImage(std::move(baseFrame), pixelSize, m_centered, m_offset);
   drawable.imagePart().addDirectivesGroup(m_processing);
   drawable.rotate(m_angle);
   drawable.color = m_color;