diff options
| author | Kai Blaschke <kai.blaschke@kb-dev.net> | 2024-02-19 16:55:19 +0100 |
|---|---|---|
| committer | Kai Blaschke <kai.blaschke@kb-dev.net> | 2024-02-19 16:55:19 +0100 |
| commit | 431a9c00a56cf4c603be1cf5f773b193621d8150 (patch) | |
| tree | 95843aeea9fb6dc18279ee05ff6961f40b19798f /source/core/StarIdMap.hpp | |
| parent | 30e1871d3f44629e00a1f66d8164e3e62c7f889f (diff) | |
Fixed a huge amount of Clang warnings
On Linux and macOS, using Clang to compile OpenStarbound produces about 400 MB worth of warnings during the build, making the compiler output unreadable and slowing the build down considerably.
99% of the warnings were unqualified uses of std::move and std::forward, which are now all properly qualified.
Fixed a few other minor warnings about non-virtual destructors and some uses of std::move preventing copy elision on temporary objects.
Most remaining warnings are now unused parameters.
Diffstat (limited to 'source/core/StarIdMap.hpp')
| -rw-r--r-- | source/core/StarIdMap.hpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source/core/StarIdMap.hpp b/source/core/StarIdMap.hpp index 1f97c55..964b899 100644 --- a/source/core/StarIdMap.hpp +++ b/source/core/StarIdMap.hpp @@ -101,7 +101,7 @@ auto IdMapWrapper<BaseMap>::nextId() -> IdType { template <typename BaseMap> void IdMapWrapper<BaseMap>::add(IdType id, MappedType mappedType) { - if (!BaseMap::insert(make_pair(move(id), move(mappedType))).second) + if (!BaseMap::insert(make_pair(std::move(id), std::move(mappedType))).second) throw IdMapException::format("IdMapWrapper::add(id, value) called with pre-existing id '{}'", outputAny(id)); } |